-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use Argparse in mdpow-pcw and mdpow-pow and add loggers #150
Conversation
We don't have argparse in Python 2 https://docs.python.org/3/library/argparse.html so I'll leave it open until we get rid of Python 2.7 |
@orbeckst It's in Python 2.7 https://docs.python.org/2.7/library/argparse.html |
Oh, I only saw the note in the 3.x page that said “added in 3.3”. That’s good then.
… Am 7/9/21 um 19:59 schrieb Shujie Fan ***@***.***>:
@orbeckst It's in Python 2.7 https://docs.python.org/2.7/library/argparse.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Codecov Report
@@ Coverage Diff @@
## develop #150 +/- ##
========================================
Coverage 68.30% 68.30%
========================================
Files 10 10
Lines 1382 1382
Branches 167 167
========================================
Hits 944 944
Misses 365 365
Partials 73 73 Continue to review full report at Codecov.
|
ping me when you need a review |
Current code cannot deal with |
@orbeckst This PR can be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc corrections to do, which I'll do before merging.
Looking good!
Note to myself: this is the log message for the squash-merge
|
…steinlab#150)" "reverting to most recent changes to resolve conflicts with merge upstream" This reverts commit 57e813b.
fix #147
-replace optparse with argparse
-add loggers to print out settings