Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Argparse in mdpow-pcw and mdpow-pow and add loggers #150

Merged
merged 15 commits into from
Jul 23, 2021

Conversation

VOD555
Copy link
Contributor

@VOD555 VOD555 commented Jun 9, 2021

fix #147
-replace optparse with argparse
-add loggers to print out settings

@orbeckst
Copy link
Member

We don't have argparse in Python 2 https://docs.python.org/3/library/argparse.html so I'll leave it open until we get rid of Python 2.7

@VOD555
Copy link
Contributor Author

VOD555 commented Jul 10, 2021

@orbeckst
Copy link
Member

orbeckst commented Jul 11, 2021 via email

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #150 (1f8ee28) into develop (6a85735) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #150   +/-   ##
========================================
  Coverage    68.30%   68.30%           
========================================
  Files           10       10           
  Lines         1382     1382           
  Branches       167      167           
========================================
  Hits           944      944           
  Misses         365      365           
  Partials        73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a85735...1f8ee28. Read the comment docs.

@VOD555 VOD555 mentioned this pull request Jul 23, 2021
3 tasks
@orbeckst
Copy link
Member

ping me when you need a review

@VOD555
Copy link
Contributor Author

VOD555 commented Jul 23, 2021

Current code cannot deal with --SI and --no-SI correctly. I'll use Argument groups for them.https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_mutually_exclusive_group

@VOD555
Copy link
Contributor Author

VOD555 commented Jul 23, 2021

@orbeckst This PR can be reviewed.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc corrections to do, which I'll do before merging.

Looking good!

@orbeckst
Copy link
Member

Note to myself: this is the log message for the squash-merge

@orbeckst orbeckst merged commit 57e813b into Becksteinlab:develop Jul 23, 2021
ALescoulie pushed a commit to ALescoulie/MDPOW that referenced this pull request Aug 1, 2021
…steinlab#150)"

"reverting to most recent changes to resolve conflicts with merge upstream"
This reverts commit 57e813b.
@VOD555 VOD555 deleted the argparse branch December 6, 2022 19:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treatment of use of SI should be transparent
2 participants