Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

strict check doesn't work in HTML files with multiple <script> tags #55

Closed
anniesullie opened this issue May 11, 2017 · 2 comments
Closed
Milestone

Comments

@anniesullie
Copy link

We're trying to use http://eslint.org/docs/rules/strict in conjunction with HTML files that can have multiple <script> tags. Unfortunately, this only checks one of the <script> tags; it seems they are concatenated.

@BenoitZugmeyer
Copy link
Owner

Thank you very much for the report. Scripts tag contents are indeed concatenated into one script source that is fed to eslint. I initially thought the "use strict" mode was applied on all inline script tags, but it is indeed wrong and thus each tags should be linted independently to fix this issue.

This would require a new major version to be released since it introduces breaking changes. I'll see if it is feasible.

@BenoitZugmeyer BenoitZugmeyer modified the milestone: v3 May 21, 2017
@BenoitZugmeyer BenoitZugmeyer removed the v3 label May 21, 2017
BenoitZugmeyer added a commit that referenced this issue May 21, 2017
@BenoitZugmeyer
Copy link
Owner

BenoitZugmeyer commented May 21, 2017

I released a beta version of eslint-plugin-html, you can test it with npm install eslint-plugin-html@next. I'll release a final version after eslint 4 is released.

Changes are listed here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants