-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: Initial MetaDrive Integration #326
Open
lola831
wants to merge
87
commits into
BerkeleyLearnVerify:main
Choose a base branch
from
lola831:test-metadrive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced 'real_time' parameter to control whether simulation runs in real time or faster. - Modified 'step' function to check elapsed time and sleep if simulation finishes faster than the specified timestep.
- Added metadrive-simulator to pyproject.toml to ensure it's installed automatically - Included sumolib as a dependency for MetaDrive to handle SUMO map features
- Added check for to ensure and are properly initialized before accessing . - Prevents when simulation is interrupted (Ctrl+C) before proper initialization. - Ensures clean shutdown of the simulator even when the simulation is manually stopped.
-Add skip for MetaDrive tests -Update test_pedestrian_movement to have specific coordinates for Car and Pedestrian
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes introduce the MetaDrive x Scenic simulator interface, allowing MetaDrive to be used within Scenic.
Key Features:
Supports Vehicle and Pedestrian objects within MetaDrive.
Adds MetaDrive as a required dependency.
Known Issues (Pending Fixes in Next MetaDrive Release):
Rendering in 3D does not work on Mac M1 devices.
Vehicles do not fully stop when applying full brakes.
These issues are already identified and will be fixed in the next MetaDrive release.
Example:
Below is an example of the MetaDrive simulator interface rendering in both 2D and 3D:
MetaDrive.2d.mov
MetaDrive.3d.mov
Issue Link
Checklist
pytest
and/or other meansAdditional Notes