Fix azure_ad_token_provider initialization for azure openai #10532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
GeminiLight
changed the title
There was a problem hiding this comment.
if azure_ad_token_provider is set - line 339 should also handle this
We also need a unit test for this flow in test_azure_common_utils.py -
There was a problem hiding this comment.
Thank you for your assistance! It is helpful for enterprise-level users to use Azure OpenAI via LiteLLM.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix azure_ad_token_provider initialization in initialize_azure_sdk_client.
Relevant issues
Fixes #6790
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
This PR addresses a bug where azure_ad_token_provider was not being correctly assigned during the initialization of the client in the initialize_azure_sdk_client function. The root cause was that the value of azure_ad_token_provider defaulted to None, instead of retrieving the correct value from the litellm_params.
Fix
The fix ensures that azure_ad_token_provider is now correctly fetched from litellm_params if available. If it is not found, it will still default to None.
Updated code snippet: