Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add lockfiles, drop EOL Ruby and Rails support while adding Ruby 3.2 compatibility #9

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Add lockfiles, drop EOL Ruby and Rails support while adding Ruby 3.2 compatibility #9

merged 8 commits into from
Jan 4, 2024

Conversation

Irving-Betterment
Copy link
Contributor

@Irving-Betterment Irving-Betterment commented Dec 27, 2023 •
edited
Loading

Summary of changes:

/task https://app.asana.com/0/1204789272404640/1206051735939413/f

@Irving-Betterment Irving-Betterment changed the title Add lockfiles Add lockfiles and drop Ruby < 3 & Rails < 6.1 support Dec 27, 2023
@Irving-Betterment Irving-Betterment changed the title Add lockfiles and drop Ruby < 3 & Rails < 6.1 support Add lockfiles Dec 27, 2023
@Irving-Betterment Irving-Betterment changed the title Add lockfiles Add lockfiles and drop Rails <6.0/Ruby <3 support Dec 27, 2023
@Irving-Betterment Irving-Betterment changed the title Add lockfiles and drop Rails <6.0/Ruby <3 support Add lockfiles and drop Rails <7.0/Ruby <3 support Dec 27, 2023
@Irving-Betterment Irving-Betterment changed the title Add lockfiles and drop Rails <7.0/Ruby <3 support Add lockfiles and drop Rails <7.0/Ruby <3.2 support Dec 27, 2023
@Irving-Betterment Irving-Betterment marked this pull request as draft December 28, 2023 16:23
@Irving-Betterment Irving-Betterment changed the title Add lockfiles and drop Rails <7.0/Ruby <3.2 support Add lockfiles Dec 28, 2023
@Irving-Betterment Irving-Betterment changed the title Add lockfiles Add lockfiles, drop EOL Ruby and Rails support while adding Ruby 3.2 compatibility Dec 28, 2023
@Irving-Betterment Irving-Betterment marked this pull request as ready for review December 28, 2023 20:46
effron
effron approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM && platformLGTM!

smudge
smudge approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM as well (to make policy bot happy)

@smudge smudge merged commit aa89581 into Betterment:main Jan 4, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@smudge smudge smudge approved these changes

@effron effron effron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Irving-Betterment @smudge @effron