feat(frontend): create auth wrapper components bb-189 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iqbalalayubbi
commented
Aug 26, 2024
•
iqbalalayubbi
commented
- Make the auth wrapper component and render header, sidebar, and other content inside
- Pass the component into a protected route component as a prop
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…4-bebalance into 189-feat-create-auth-wrapper-components
iqbalalayubbi
requested review from
fshabanov,
WilhelmWesser,
anogire,
revenets and
ViktoriiaKozopas
as code owners
fshabanov
requested changes
Aug 26, 2024
Comment on lines
7
to
11
| <> | ||
| <Header /> | ||
| <Sidebar /> | ||
| <QuizForm /> | ||
| </> |
There was a problem hiding this comment.
Make sure to keep styling, add a screenshot to this PR
There was a problem hiding this comment.
the root page look like this
There was a problem hiding this comment.
The layout is not correct. Sidebar should be on the left side
There was a problem hiding this comment.
i try to make the style for auth wrapper and look like this
fshabanov
requested changes
Aug 26, 2024
Comment on lines
7
to
11
| <> | ||
| <Header /> | ||
| <Sidebar /> | ||
| <QuizForm /> | ||
| </> |
There was a problem hiding this comment.
The layout is not correct. Sidebar should be on the left side
apps/frontend/src/libs/components/protected-route/protected-route.tsx
Outdated
Show resolved
Hide resolved
…4-bebalance into 189-feat-create-auth-wrapper-components
fshabanov
requested changes
Aug 26, 2024
apps/frontend/src/libs/components/auth-wrapper.tsx/auth-wrapper.tsx
Outdated
Show resolved
Hide resolved
fshabanov
requested changes
Aug 26, 2024
apps/frontend/src/libs/components/auth-wrapper.tsx/auth-wrapper.tsx
Outdated
Show resolved
Hide resolved
fshabanov
approved these changes
Aug 26, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.