Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Comments color #713

Closed
zprjk opened this issue Apr 21, 2022 · 4 comments
Closed

Comments color #713

zprjk opened this issue Apr 21, 2022 · 4 comments
Labels
bug issue confirm WIP Work In Process

Comments

@zprjk
Copy link

zprjk commented Apr 21, 2022

Describe the bug
The Comments color seems off put in One Dark Pro Theme. It wasn't like this before. Picking One Dark Pro Darker the colouring goes back like before (more grayish).

theme.mp4

image

image

Expected behavior
I expected the comments colouring more grayish.

Desktop (please complete the following information):

  • OS: Mac
  • VSCODE Version: v1.66.2
  • Theme version: v3.13.22
@zprjk zprjk added the bug label Apr 21, 2022
@zprjk
Copy link
Author

zprjk commented Apr 21, 2022

I've being using the One Dark Pro theme since my first extension installation. If this not a bug can I override the color?

Many Thanks.

@Binaryify Binaryify added WIP Work In Process issue confirm labels Apr 21, 2022
@Binaryify
Copy link
Owner

it is a bug, will fix it soon

Binaryify added a commit that referenced this issue Apr 21, 2022
@Binaryify
fix: Fix theme config array merge bug #713
88e6160
@Binaryify
Copy link
Owner

Binaryify commented Apr 21, 2022 •
edited
Loading

plz check v3.13.23

@zprjk
Copy link
Author

zprjk commented Apr 21, 2022

Fixed. Thx !

@zprjk zprjk closed this as completed Apr 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug issue confirm WIP Work In Process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zprjk @Binaryify