forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add CI for Go #77
Merged
Merged
Add CI for Go #77
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a032fa5
Add CI build workflow
aaron-congo debde9d
Add unit test, static code analysis
aaron-congo d727713
Debug build failure
aaron-congo 76480fd
Add tools.go
aaron-congo 258fc6b
Add makefile
aaron-congo b5f5db4
Fix build errors
aaron-congo 40610b1
Add AL2 build job
aaron-congo 4fb3978
Remove build.rs
aaron-congo 920c051
Remove cbindgen from Cargo.toml
aaron-congo a9564f6
Polish minor mistakes
aaron-congo 78e463b
Minor changes
aaron-congo 44767d6
Update make install-tools to parse tools.go
aaron-congo 877d376
Fix build error
aaron-congo 8350d8d
Change staticheck version to support go 1.18
aaron-congo d7f079d
PR suggestions
aaron-congo 6c749b5
PR suggestions
aaron-congo 9aac6e7
PR suggestions
aaron-congo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add AL2 build job
- Loading branch information
commit 40610b10c3f1a1ec421a6722bbc15bbd8d1164ca
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you use
actions/setup-go
there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? I saw that Java uses setup-java for ubuntu/macos but not for amazon linux so I assumed setup-java did not work on amazon linux and that if it doesn't work for java that it wouldn't for go. But my assumption may be wrong