This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
add support for windows ssh-agent #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackReloaded
suggested changes
May 4, 2020
main.go
Outdated
Comment on lines
157
to
162
| } else if *ssh != "" { | ||
| handlePipedSSH() | ||
| } else { | ||
| handleSSH() | ||
| } |
There was a problem hiding this comment.
Use early return instead of complicated if else structure
Windows 10 has the optional feature for an ssh client. This package comes with a backed in ssh-agent which utilizes windows named pipes instead of unix sockets. This CL adds support to communicate which such ssh-agent. This is mainly needed to enable ssh agents which do not support the pageant established "protocol". Signed-off-by: Tobias Kohlbau <tobias@kohlbau.de>
tobiaskohlbau
force-pushed
the
feature/addWindowsSSH
branch
from
becc694 to
cfb1ff2
Compare
BlackReloaded
approved these changes
May 19, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 10 has the optional feature for an ssh client.
This package comes with a backed in ssh-agent which
utilizes windows named pipes instead of unix sockets.
This CL adds support to communicate which such ssh-agent.
This is mainly needed to enable ssh agents which do
not support the pageant established "protocol".
Signed-off-by: Tobias Kohlbau tobias@kohlbau.de