-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added bUnit extention and test examples to Toast #117
Conversation
OliverBack
commented
Jun 11, 2021
•
edited
Loading
edited
- Added BUnitToastTestExtensions helper to register toast services
- Added sample tests
- Added unit tests for Toast Service
Added unit tests for ShowInfo, ShowSuccess, ShowToast and ShowWarning for ToastServiceTests
@egil do you have any thoughts on the bUnit test extensions? |
More questions :-) I was expecting to see a fake implementation of |
@egil Yep. That's a fair point. We got a little bit carried away here in hindsight. You're correct, we don't need to actually render the toasts at all. We'll rework this. |
Been there done that. My suggestion is to create a fake service that has a few query methods that users can easily combine with their assertion framework of choice. |
Created TestExtensions project updated ci-pr.yml build step
@egil Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a few suggestions for you.
@chrissainty - Any idea when this PR will be completed? |
Co-authored-by: Egil Hansen <egil@assimilated.dk>
I'm hoping very soon. @OliverBack any ideas when we'll be done on this? |
Co-authored-by: Egil Hansen <egil@assimilated.dk>
@chrissainty, @anitagov Hopefully have the pr ready for today |
Co-authored-by: Egil Hansen <egil@assimilated.dk>
exposed inmemory toats list
Thanks for adding this feature @chrissainty . |