-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Pronunciations refactoring #1377
Conversation
I reviewed completely how pronunciations were retrieved in order to tackle that task, including changing where pronunciations were looked for: before we were using the whole word wikicode, now we only use `head_sections` wikicode (faster, and more efficient). It has the following nice side-effects (on top the having local-specific formatting like `\...\` for French, `[...]` for German, etc.): - `EN`, `FR`: now supports multiple cross-sections pronunciations (like ones from Middle English combined to ones from Old English sections, for instance on English data) - `FR`: pronunciations outside the French section are no more taken into account (like using values from Gaulois or other locale sections, that was incorrect) - `PT`: a lot more pronunciations are correctly found now - `SV`: multiple pronunciations are now supported - `RU`: it will be way easier to tackle #1376 then
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.72%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Fixes #1174.
I reviewed completely how pronunciations were retrieved in order to tackle that task, including changing where pronunciations were looked for: before we were using the whole word wikicode, now we only use
head_sections
wikicode (faster, and more efficient).It has the following nice side-effects (on top the having local-specific formatting like
\...\
for French,[...]
for German, etc.):EN
,FR
: now supports multiple cross-sections pronunciations (like ones from Middle English combined to ones from Old English sections, for instance on English data)FR
: pronunciations outside the French section are no more taken into account (like using values from Gaulois or other locale sections, that was incorrect)PT
: a lot more pronunciations are correctly found nowSV
: multiple pronunciations are now supportedRU
: it will be way easier to tackle [RU] Decode pronunciations #1376 then