Add additional feat-image controls for post headers #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avonville
approved these changes
Jan 23, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
If I have Content Container for Page Titles set to full width and Featured Image Above Header / Image / Medium / Left the image appears right next to the page title |
Merged
This comment was marked as resolved.
This comment was marked as resolved.
|
% control doesn't work as expected, okay to just remove entirely. |
jamesros161
added a commit
that referenced
this pull request
Feb 14, 2023
* add filters for prev / next links (#22) * add action for crio pro (#28) * add action for crio pro * undo margin-fix.scss change * Crio pro issue 114 (#27) * add action for crio pro * add color-classes for links to comments * add comment filters * update edit exclusions * update button edit-vars * update _comments.scss * set versions * add show / hide date * change selector for margin * add min-height to heading w/ avatar * add filters for prev / next links (#29) * add Mega Menus to Pro Features (#8) * add Mega Menus to Pro Features * update versions for PR * Add 'published' or 'modified' post meta date control (#13) * set versions * add control and filters for showing updated time * Add alignment controls for post list 'entry-footer' links (#11) * add blog page entry-footer link alignment controls * fix off-center * re-add missing comment icon controls * Remove links from page / post / blog / archive titles (#15) * remove link from page, post, blog & archive titles * update versions for PR * fix title color and title font size controls * update versions * Add additional feat-image controls for post headers (#17) * update version for branch * add templates for featured image positions * update controls (#16) * phpcs corrections * update version for issue-9-alpha * change bg height control * add tooltip * fix image padding / margins * fix max-full-width flex direction * MFW fixes * fix 'hide' not working * add js to place img inside content * fix page title divided * update versions * update changelog * minor css fixes * fix hidden post image not showing on post list * update versions for RC * remove % units * set version for stable * add comments * fix file dockblocks * remove extra lines
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
crio-2.19.0-issue-9.zip
Testing Instructions
Design > Blog > Posts > Featured ImagesPositioncontrol. They should beHeader Background, Above Header, Below Header, and In ContentAbove Header and Below Headeryou will see another control appear calledFeatured Image Display Typewhich will allow you to select eitherBackgroundorImage. Ensure both options display correctly in both positions, in the preview and when published.backgroundyou will see a slider show up allowing you to specify the height of the background. Ensure the control changes are reflected in the preview and when published, for both above and below header.imageyou can select the image size and alignment. Ensure these controls are working in the preview and when published.In Contentensure that the image size and alignment controls are shown, and work as expected.