Skip to content

Commit

Permalink
fix multi-install gui
Browse files Browse the repository at this point in the history 
apps are separated by newlines when multi-install/multi-uninstall is called, not spaces
  • Loading branch information
@theofficialgman
theofficialgman committed May 16, 2022
1 parent aa88cf4 commit b6d71aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion manage
View file
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ elif [ "$1" == 'multi-uninstall' ] || [ "$1" == 'multi-install' ];then

#install/uninstall one app at a time. If it fails then add the app to the list of failed apps
failed_apps=''
for app in $app_list ;do
echo "$app_list" | while read app;do

"${DIRECTORY}/manage" $action "$app"
if [ $? != 0 ];then
Expand Down

3 comments on commit b6d71aa

@Botspot
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually loop through newline-separated lists with a for loop. If it didn't work this time then it seems like a simple IFS=$'\n' would have fixed it.

@theofficialgman
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually loop through newline-separated lists with a for loop. If it didn't work this time then it seems like a simple IFS=$'\n' would have fixed it.

I tried that... and it didn't work

@Botspot
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that... and it didn't work

It worked fine for me. I've removed this unnecessary use of echo with commit 689f767.

Please # to comment.