Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Port FPM/FM local buffer functionality #24

Open
WhiteTPoison opened this issue Jun 11, 2022 · 0 comments
Open

Port FPM/FM local buffer functionality #24

WhiteTPoison opened this issue Jun 11, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@WhiteTPoison
Copy link
Member

See this PR for functionality that is to be ported: FasterMelee/6.0-wip@2df5dbb

@WhiteTPoison WhiteTPoison added enhancement New feature or request good first issue Good for newcomers labels Jun 11, 2022
WhiteTPoison pushed a commit that referenced this issue Dec 8, 2022
When a guest register is an immediate, it may be necessary to move this
value into a register. This is handled by gpr.R(), which lacks context
on how the register will be used. This leads to cases where the
immediate is written to a register, only for it to be overwritten. Take
for example this code generated by srwx:

0x5280031b   mov    w27, #0x18
0x53187edb   lsr    w27, w22, #24

gpr.BindToRegister() does have this context through the do_load
parameter, but didn't handle immediates. By adding this logic, we can
intelligently skip the write when do_load is false.
@WhiteTPoison WhiteTPoison moved this to Todo in Brawlback Board Feb 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

1 participant