Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update read_bodc dimension to include id_dim #623

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

jpolton
Copy link
Collaborator

@jpolton jpolton commented Aug 24, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (./build.sh) was run locally and no errors reported. NB not sure about this requirement: GitActions test this
  • Lint (pylint .) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this with black

Pull request type

Update read_bodc method to include awareness of id_dim
Make these data loads consistent with data objects from read_gesla.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Error when trying to use obs_operator() on data object generated with tidegauge.read_bodc()
Method is missing latitude and longitude coords. (There are in attributes)

Issue URL: #

What is the new behavior?

No error when trying to use obs_operator() on data object generated with tidegauge.read_bodc()
Lat and lon are now coordinates and not attributes.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing (pip install . && pytest unit_testing/unit_test.py -s)
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Does this introduce a breaking change?

  • Yes
  • No

@jpolton jpolton self-assigned this Aug 24, 2023
@jpolton jpolton merged commit 3d7bc2c into develop Oct 13, 2023
@jpolton jpolton deleted the feature/reformat_read_bodc branch October 13, 2023 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant