update read_bodc dimension to include id_dim #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
COAsT-site
repo, in a separate PR. See contributing to documentation for details../build.sh
) was run locally and no errors reported. NB not sure about this requirement: GitActions test thispylint .
) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this withblack
Pull request type
Update read_bodc method to include awareness of id_dim
Make these data loads consistent with data objects from read_gesla.
Please check the type of change your PR introduces:
What is the current behavior?
Error when trying to use obs_operator() on data object generated with tidegauge.read_bodc()
Method is missing latitude and longitude coords. (There are in attributes)
Issue URL: #
What is the new behavior?
No error when trying to use obs_operator() on data object generated with tidegauge.read_bodc()
Lat and lon are now coordinates and not attributes.
Checklist
pip install . && pytest unit_testing/unit_test.py -s
)Does this introduce a breaking change?