Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tidy up example scripts directory #634

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

roje-bodc
Copy link
Collaborator

@roje-bodc roje-bodc commented Nov 2, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (./build.sh) was run locally and no errors reported. NB not sure about this requirement: GitActions test this
  • Lint (pylint .) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this with black

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: #

What is the new behavior?

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing (pip install . && pytest unit_testing/unit_test.py -s)
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Does this introduce a breaking change?

  • Yes
  • No

Other information

@roje-bodc roje-bodc linked an issue Nov 2, 2023 that may be closed by this pull request
@roje-bodc roje-bodc mentioned this pull request Nov 2, 2023
@roje-bodc roje-bodc requested a review from jpolton November 2, 2023 10:22
@roje-bodc
Copy link
Collaborator Author

Re-added the configuration files that we want to keep

Copy link
Collaborator

@jpolton jpolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great. All good. (NB incase someone rediscovers this. The configuration_gallery/ scripts do not automatically generate markdown as the source data is not available to Git Actions)

@roje-bodc roje-bodc merged commit 4b047d5 into develop Nov 2, 2023
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy notebooks
2 participants