Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Rotation3d and Roll Getters #15

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix Rotation3d and Roll Getters #15

merged 2 commits into from
Feb 15, 2023

Conversation

7910f6ba7ee4
Copy link
Contributor

  • Rotation3d initializes with roll, pitch, yaw, not yaw, pitch, roll (I'm not sure why exactly). Changed to fit that.
  • also fix getRoll to return roll ypr[2] instead of pitch

@thenetworkgrinch thenetworkgrinch merged commit f5cea45 into BroncBotz3481:main Feb 15, 2023
@thenetworkgrinch
Copy link
Contributor

I did not notice that 😅 Thank you!

@7910f6ba7ee4 7910f6ba7ee4 deleted the patch-rotation3dfix branch February 17, 2023 03:41
thenetworkgrinch pushed a commit that referenced this pull request Dec 18, 2024
@clrozeboom
Merge pull request #15 from FRC5010/dev
76f8b86 
Update thrifty_nova from Dev
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7910f6ba7ee4 @thenetworkgrinch