Fix TalonFX Support (Position Conversion Error) #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if this is the entire fix. I tested the current full upstream version of the library today, but there were issues driving. When debugging in Glass, the problem appeared to occur between the "Module Angle Setpoint" and "Optimized Module Setpoint" NT entries. The only step between these two is the actual optimization, which uses
getState()
, which relies on position.I'm pretty sure this is the only significant difference between this and https://github.com/FRC1466/robot-code-2023/tree/main/src/main/java/swervelib, the version I switched to that worked. I won't be able to physically test this until Thursday unfortunately.
I also removed the difference between
getRawPosition
andgetPosition
since I've been using the latter in my local code and it works the same.