Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix TalonFX Support (Position Conversion Error) #23

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

7910f6ba7ee4
Copy link
Contributor

I'm not entirely sure if this is the entire fix. I tested the current full upstream version of the library today, but there were issues driving. When debugging in Glass, the problem appeared to occur between the "Module Angle Setpoint" and "Optimized Module Setpoint" NT entries. The only step between these two is the actual optimization, which uses getState(), which relies on position.

I'm pretty sure this is the only significant difference between this and https://github.com/FRC1466/robot-code-2023/tree/main/src/main/java/swervelib, the version I switched to that worked. I won't be able to physically test this until Thursday unfortunately.

I also removed the difference between getRawPosition and getPosition since I've been using the latter in my local code and it works the same.

@thenetworkgrinch
Copy link
Contributor

Thank you for testing! I will merge your changes after testing on thursday.

@7910f6ba7ee4
Copy link
Contributor Author

Testing works with latest, should be alright to merge

@thenetworkgrinch thenetworkgrinch merged commit 1e37a3c into BroncBotz3481:main Feb 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants