Use worker pool for parallel jobs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each workflow run has a UUID generated for it when it is started. This UUID is added to the container name of each job in a run. This means that multiple instances of act can run on the same workflow without their containers' names conflicting.
* Add "/artifacts" as a mount * Only remove job container if the job succeeds or if `--rm` given Previously, the container would be removed no matter what. Now, users can leave off the `--rm` flag to leave containers running if they fail, which can aid in debugging.
The intended behavior is for 'include' directives to modify existing entries if their common keys match, and to only add new entries if they cannot modify any existing entry. Previously, 'include' directives had no effect if they had no keys in common with an existing entry, and always added new entries if they did.
When a workflow tries to run actions/checkout, the runner needs to know if the
workflow wants to check out the current repository or a remote repository. It
does this by comparing the provided repository name and ref with those of the
current branch. This commit expands expressions in those fields before the
comparison, so workflows can call actions/checkout with parameters like
"ref: {{ SOME_VARIABLE }}".
|
Does this increase the runtime significantly? |
ryanajae
approved these changes
Apr 26, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version started all parallel jobs at once, no matter how many jobs there were. This behavior could lead to a huge number of docker containers all being run at once, which slowed down the host machine considerably. This PR fixes that issue by using a worker pool to limit the number of jobs that can be run in parallel. Currently, the maximum number is hardcoded to 4.