Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support eth_getLogs query with blockHash params. #480

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Support eth_getLogs query with blockHash params. #480

merged 1 commit into from
Nov 24, 2024

Conversation

c98tristan
Copy link
Contributor

This PR support eth_getLogs query with blockHash params. to support query transaction logs.

  1. Derive FilterCriteria from ethereum.FilterQuery
  2. Add BlockHash to FilterCriteria
  3. Unit testing

Reference:

@c98tristan c98tristan changed the base branch from master to pre-release November 22, 2024 08:51
@c98tristan c98tristan marked this pull request as ready for review November 22, 2024 08:52
@tungng98
Copy link
Collaborator

Great finding and implementation

@tungng98 tungng98 merged commit 6ea52b8 into BuildOnViction:pre-release Nov 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tungng98 tungng98 tungng98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c98tristan @tungng98