Add EIA ID to Utility #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macintoshpie
added
Schema: General
|
@corymosiman12 Can you improve the description if needed? |
markborkum
reviewed
Sep 24, 2020
macintoshpie
force-pushed
the
feat/eia-utility-id
branch
from
457abf7 to
33ae4ab
Compare
corymosiman12
suggested changes
Sep 24, 2020
BuildingSync.xsd
Outdated
| @@ -3736,6 +3736,11 @@ | |||
| </xs:restriction> | |||
| </xs:simpleType> | |||
| </xs:element> | |||
| <xs:element name="EIAUtilityID" type="xs:nonNegativeInteger" minOccurs="0"> | |||
| <xs:annotation> | |||
| <xs:documentation>ID of the OpenEI EIA Utility.</xs:documentation> | |||
There was a problem hiding this comment.
"EIA Utility ID as found in EIA-861 and as available in OpenEI"
macintoshpie
force-pushed
the
feat/eia-utility-id
branch
from
33ae4ab to
edcf05c
Compare
corymosiman12
approved these changes
Sep 25, 2020
markborkum
approved these changes
Sep 25, 2020
refactor(schema): change EIAUtilityID type to nonnegative int doc(schema): update EIAUtilityID docs
macintoshpie
force-pushed
the
feat/eia-utility-id
branch
from
edcf05c to
52a5b37
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be nice to have these IDs for identifying utility types: https://openei.org/wiki/List_of_United_States_Utility_Companies_and_Aliases#cite_note-1