Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add MROE eGridRegion #279

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Add MROE eGridRegion #279

merged 5 commits into from
Dec 16, 2020

Conversation

nllong
Copy link
Member

@nllong nllong commented Dec 16, 2020

This addressed the first half of #276 by adding MROE and adding the deprecation warning.

@nllong nllong requested a review from markborkum December 16, 2020 13:41
BuildingSync.xsd Outdated Show resolved Hide resolved
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

Please revert the change to the XSD file. It should be in a separate pull request.

@nllong nllong requested a review from markborkum December 16, 2020 15:26
@nllong nllong merged commit df5237d into develop Dec 16, 2020
@nllong nllong deleted the bug/276-egridregion branch December 16, 2020 15:50
@nllong nllong added Schema: General General update to BuildingSync bug Non-breaking Change labels Dec 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Non-breaking Change Schema: General General update to BuildingSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants