Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add SpatialUnits #299

Merged
merged 7 commits into from
May 5, 2021
Merged

Add SpatialUnits #299

merged 7 commits into from
May 5, 2021

Conversation

corymosiman12
Copy link
Contributor

  • see proposal
  • implementation in schema added

@corymosiman12 corymosiman12 added Non-breaking Change feature Adding new functionality to BuildingSync UDFs labels Mar 2, 2021
@yan130 yan130 self-requested a review March 3, 2021 17:41
@corymosiman12 corymosiman12 requested a review from nllong March 10, 2021 17:45
@yan130
Copy link

yan130 commented Mar 15, 2021

Could I know this PR is for which UDF?

@corymosiman12
Copy link
Contributor Author

Hi Yan - we have been trying to link all PRs back to the UDFs spreadsheet for reference. Let me know that you find it!

@nllong
Copy link
Member

nllong commented Apr 16, 2021 •
edited
Loading

Hi @yan130 , can you review this proposal when you get a chance?

@yan130
Copy link

yan130 commented Apr 28, 2021

This change will not have influence on AT's XML.

@nllong nllong self-assigned this Apr 30, 2021
@nllong
Copy link
Member

nllong commented Apr 30, 2021

@JieXiong9119 -- can you dedupe the SpatialUnit complex name type?

Thanks!

@nllong nllong assigned JieXiong9119 and unassigned nllong Apr 30, 2021
@nllong
Copy link
Member

nllong commented May 5, 2021

@JieXiong9119 -- can you dedupe the SpatialUnit complex name type?

Thanks!

Hey @JieXiong9119 -- I added spatialunit and spatialunits to the exclusion for the tests. We would need to create a breaking change to address this, so let's wait on that.

@nllong nllong merged commit c0db78f into develop May 5, 2021
@nllong nllong deleted the proposals/section-spatial-units branch May 5, 2021 16:59
@JieXiong9119 JieXiong9119 changed the title Proposals/section spatial units Add SpatialUnits Sep 27, 2021
@JieXiong9119 JieXiong9119 added the Schema: General General update to BuildingSync label Sep 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yan130 yan130 yan130 approved these changes

@aviveiros11 aviveiros11 Awaiting requested review from aviveiros11

@JieXiong9119 JieXiong9119 Awaiting requested review from JieXiong9119

@nllong nllong Awaiting requested review from nllong

@macintoshpie macintoshpie Awaiting requested review from macintoshpie

Assignees

@JieXiong9119 JieXiong9119

Labels
feature Adding new functionality to BuildingSync Non-breaking Change Schema: General General update to BuildingSync UDFs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corymosiman12 @yan130 @nllong @macintoshpie @JieXiong9119