Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add AuditFilingStatus #308

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Add AuditFilingStatus #308

merged 4 commits into from
Mar 23, 2021

Conversation

JieXiong9119
Copy link
Contributor

See proposal
Implementation in schema added

BuildingSync.xsd Outdated Show resolved Hide resolved

## Justification

This field is only specific to Atlanta reports, but could be a useful input for others if requested.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey Jie - I think just clarify with this justification section that this originally came about in working directly with the city of Atlanta, but we believe it is a good field and therefore are adding it to the schema...something like that.

BuildingSync.xsd Outdated Show resolved Hide resolved
Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested. I think changing to Amended filing is the correct approach.

1. Rephrased Justification in Readme file and description in schema.
2. Corrected capitalization.
Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nllong nllong merged commit 56e1b65 into develop Mar 23, 2021
@nllong nllong deleted the proposal/audit-filing-status branch March 23, 2021 19:50
@JieXiong9119 JieXiong9119 changed the title Proposals/audit filing status Add AuditFilingStatus Sep 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature Adding new functionality to BuildingSync Non-breaking Change UDFs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants