-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add MultiTenant #310
Merged
Merged
Add MultiTenant #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed `TotalExteriorRoofArea` to `TotalRoofArea`. 2. Created new simple type for `nonNegativeDecimal` and applied for the added element.
yan130
approved these changes
Mar 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be captured by an OccupancyClassification?
There are probably many different occupancy classifications that might be multi-tenant (office, mixed commercial, retail, etc.), but even within those it's not always guaranteed. This makes it clear. |
corymosiman12
approved these changes
Mar 23, 2021
nllong
reviewed
Mar 23, 2021
nllong
approved these changes
Mar 23, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
feature
Adding new functionality to BuildingSync
Non-breaking Change
Schema: General
General update to BuildingSync
UDFs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal
Implementation in schema added