Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate MORE in eGRIDRegionCode #342

Merged
merged 3 commits into from
May 19, 2021
Merged

Deprecate MORE in eGRIDRegionCode #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cb46cf
Deprecate MORE in eGRIDRegionCode
JieXiong9119 May 6, 2021
5ad2892
Merge branch 'develop-v3' into deprecate/MORE-in-eGRIDRegionCode
nllong May 7, 2021
6cfecef
Merge branch 'develop-v3' into deprecate/MORE-in-eGRIDRegionCode
nllong May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BuildingSync.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17610,7 +17610,6 @@
<xs:enumeration value="FRCC"/>
<xs:enumeration value="HIMS"/>
<xs:enumeration value="HIOA"/>
<xs:enumeration value="MORE"/>
<xs:enumeration value="MROE"/>
<xs:enumeration value="MROW"/>
<xs:enumeration value="NEWE"/>
Expand Down
11 changes: 11 additions & 0 deletions proposals/2021/Deprecate MORE in eGRIDRegionCode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Deprecate MORE in eGRIDRegionCode

## Overview

This proposal is to deprecate the enumeration `MORE` under `eGRIDRegionCode` element.

## Justification

`MORE` should be `MROE`. This typo bug was raised in issue [#276](https://github.com/BuildingSync/schema/issues/276) and partially addressed in PR [#279](https://github.com/BuildingSync/schema/pull/279) by adding the correct enumeration. Removing `MORE` will fix the last piece of the problem.

## References