Deprecate DoorID and WindowID as direct Child under Side #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create proposal Implement in schema Transform examples
This was
linked to
issues
Jun 9, 2021
nllong
reviewed
Jun 10, 2021
| @@ -52,4 +52,18 @@ Version: 0.1.0 | |||
| </xsl:comment> | |||
| </xsl:template> | |||
|
|
|||
| <!-- Transform auc:WindowID element under auc:Side to auc:WindowIDs/auc:WindowID element --> | |||
nllong
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Looks great! @macintoshpie feel free to merge down after you take a look.
macintoshpie
approved these changes
Jun 10, 2021
Comment on lines
+34
to
+36
| <!--xsl:template match="@xsi:schemaLocation"> | ||
| <xsl:attribute name="xsi:schemaLocation">http://buildingsync.net/schemas/bedes-auc/2019 https://raw.githubusercontent.com/BuildingSync/schema/v3.0.0/BuildingSync.xsd</xsl:attribute> | ||
| </xsl:template> | ||
| </xsl:template--> |
There was a problem hiding this comment.
I'm ok with this for now, but maybe we should tweak our examples so that we can allow this to be included. e,g, if a user has a schemalocation that points to an older version then it'll be incorrect
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposals.
Resolve #234 #235