Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed incidents #13

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Closed incidents #13

merged 2 commits into from
Aug 7, 2024

Conversation

Bullrich
Copy link
Owner

@Bullrich Bullrich commented Aug 7, 2024

Fixed bug where closed incidents wouldn't appear.

Also added extra workflow trigger to the health check. Now it will run on the creation of an issue (so it can respond faster to incidents)

Summary by CodeRabbit

  • New Features
    • Enhanced GitHub Actions workflow to trigger health checks based on issue events (opened and closed).
    • Expanded incident reporting to include all issues regardless of their status (open or closed).

These changes improve the responsiveness of automated health checks and provide a more comprehensive view of incidents within the repository.

This allows faster build time based on a label being created or deleted
@Bullrich Bullrich added the bug Something isn't working label Aug 7, 2024
@Bullrich Bullrich self-assigned this Aug 7, 2024
Copy link

coderabbitai bot commented Aug 7, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This update enhances the GitHub Actions workflow by adding an issues event trigger, enabling health checks to respond dynamically to issue openings and closures. Additionally, modifications in the IncidentManager class expand the retrieval of incidents to include all issues, enhancing oversight of both open and closed incidents. These changes collectively improve the workflow's responsiveness and functionality in managing repository health and incident tracking.

Changes

Files Change Summary
.github/workflows/health-check.yml Added an issues event trigger for opened and closed, allowing health checks to respond dynamically to issue events.
log/src/github/incidents.ts Modified obtainPastIncidents method to include state: "all", allowing retrieval of both open and closed issues for better incident management.

Poem

🐇 In the garden of code, changes bloom bright,
With issues now heard, oh what a delight!
Incidents gathered, both open and closed,
Our workflow now dances, no longer enclosed.
So hop with me, friends, through this digital glade,
For every new feature, a celebration is made! 🥳✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Bullrich Bullrich enabled auto-merge (squash) August 7, 2024 08:42
@Bullrich Bullrich disabled auto-merge August 7, 2024 08:42
@Bullrich Bullrich merged commit c586313 into main Aug 7, 2024
8 checks passed
@Bullrich Bullrich deleted the closed-incidents branch August 7, 2024 08:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant