Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support riscv32imc-unknown-none-elf #162

Closed
lu-zero opened this issue Nov 21, 2024 · 3 comments · Fixed by #177
Closed

Support riscv32imc-unknown-none-elf #162

lu-zero opened this issue Nov 21, 2024 · 3 comments · Fixed by #177
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lu-zero
Copy link
Contributor

lu-zero commented Nov 21, 2024

There are few uses of Arc and those are missing for the target.
Would it be acceptable to add portable-atomic and portable-atomic-util and the required knobs to support it?

@BurntSushi
Copy link
Owner

I am okay with it as long as they are only included and used for targets that specifically need them.

Another option is to just not use an Arc on those targets and instead use a Box. It might lead to higher memory usage and longer clones. This is probably not great, specifically, for the case of TimeZone which is really designed to be cheap to clone. So probably the target specific dependency is worth it.

@BurntSushi BurntSushi added the enhancement New feature or request label Nov 21, 2024
@BurntSushi BurntSushi added the help wanted Extra attention is needed label Dec 27, 2024
@BurntSushi
Copy link
Owner

I don't have any experience with targets like riscv32imac-unknown-none-elf, so this is probably going to require someone other than me to contribute support here.

My main requirement here is that Jiff does not grow more dependencies in the general case. I am okay with target specific dependencies that carry their weight. A brief glance suggests that portable-atomic does, but I wouldn't want to bring that dependency in for, say, x86-64 or aarch64.

@lu-zero lu-zero changed the title Support riscv32imac-unknown-none-elf Support riscv32imc-unknown-none-elf Dec 27, 2024
@lu-zero
Copy link
Contributor Author

lu-zero commented Dec 27, 2024

Let me prepare something, it is riscv32imc-unknown-none-elf the problematic one.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants