Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[build-dependencies] don't get tracked as needing publishing, don't get published first as needed #16

Open
MingweiSamuel opened this issue Jan 29, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MingweiSamuel
Copy link
Contributor

No description provided.

@Byron Byron added enhancement New feature or request help wanted Extra attention is needed labels Jan 29, 2024
@MingweiSamuel MingweiSamuel changed the title [build-dependencies] don't get tracked as needing publishing [build-dependencies] don't get tracked as needing publishing Mar 2, 2024
@MingweiSamuel
Copy link
Contributor Author

MingweiSamuel commented Apr 10, 2024

A very naive grep through the code points to this line maybe being relevant

.filter(|d| d.kind == DependencyKind::Normal)

@MingweiSamuel MingweiSamuel changed the title [build-dependencies] don't get tracked as needing publishing [build-dependencies] don't get tracked as needing publishing, don't get published first as needed Apr 10, 2024
@Byron
Copy link
Owner

Byron commented Apr 10, 2024

You can probably try that locally in a project that would need it. It's also the only place that seems to filter by kind, so I'd say it's indeed promising.

@MingweiSamuel
Copy link
Contributor Author

Seems like it might be an issue with [dev-dependencies] as well (not being accounted for in the topological sort)

@Byron
Copy link
Owner

Byron commented May 25, 2024

dev-dependencies that are also in the workspace must use { path = "<path-to-crate>" } without mentioning any version. Otherwise it definitely breaks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants