Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use icons from icon theme #1

Merged
merged 8 commits into from
Jun 20, 2024
Merged

use icons from icon theme #1

merged 8 commits into from
Jun 20, 2024

Conversation

tgilgien
Copy link
Contributor

This commit makes the app try to use the icons from the current icon theme, and falls back to the bundled ones if none is available.

Icon recoloring is not supported, so themes relying on it (e.g. breeze dark) will look broken (dark icons on dark background). Note that the current implementation always use dark icons even when using a dark color scheme.

This commit makes the app try to use the icons from the current icon
theme, and falls back to the bundled ones if none is available.

Icon recoloring is not supported, so themes relying on it (e.g. breeze
dark) will look broken (dark icons on dark background). Note that the
current implementation always use dark icons even when using a dark
color scheme.
@Bzero
Copy link
Owner

Bzero commented Jun 19, 2024

Thanks a lot for this pull request! Using the icon theme does make sense and hopefully makes the application look a bit more native for users that prefer that.

Could you please run ruff check and make sure that your changes adhere to the ruff linting and formatting rules? (I'm sorry that there is no github action in place yet that automatically enforces this, I will add that shorty).

typstwriter/actions.py Outdated Show resolved Hide resolved
typstwriter/editor.py Outdated Show resolved Hide resolved
typstwriter/util.py Outdated Show resolved Hide resolved
typstwriter/util.py Show resolved Hide resolved
tgilgien and others added 6 commits June 20, 2024 09:16
@tgilgien
Copy link
Contributor Author

Thanks for the feedback!

I made the necessary changes to pass ruff check. (Btw, I'm rather new to python development, so don't hesitate to be harsh on style)

@Bzero
Copy link
Owner

Bzero commented Jun 20, 2024

Great, this is all looking good to me.

I made the necessary changes to pass ruff check. (Btw, I'm rather new to python development, so don't hesitate to be harsh on style)

I think a quick ruff format will fix the remaining formatting issues. I am myself not very picky about code style or formatting but I think following a standard eases the collaboration when multiple people work on a project.

@Bzero Bzero merged commit 825eebd into Bzero:master Jun 20, 2024
4 checks passed
@Bzero
Copy link
Owner

Bzero commented Jun 20, 2024

Thanks a lot for your work, very much appreciated!

@tgilgien tgilgien deleted the themable-icons branch June 20, 2024 14:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants