-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
use icons from icon theme #1
Conversation
This commit makes the app try to use the icons from the current icon theme, and falls back to the bundled ones if none is available. Icon recoloring is not supported, so themes relying on it (e.g. breeze dark) will look broken (dark icons on dark background). Note that the current implementation always use dark icons even when using a dark color scheme.
Thanks a lot for this pull request! Using the icon theme does make sense and hopefully makes the application look a bit more native for users that prefer that. Could you please run |
Co-authored-by: Bzero <lolo-b@posteo.net>
Co-authored-by: Bzero <lolo-b@posteo.net>
Co-authored-by: Bzero <lolo-b@posteo.net>
Thanks for the feedback! I made the necessary changes to pass |
Great, this is all looking good to me.
I think a quick |
Thanks a lot for your work, very much appreciated! |
This commit makes the app try to use the icons from the current icon theme, and falls back to the bundled ones if none is available.
Icon recoloring is not supported, so themes relying on it (e.g. breeze dark) will look broken (dark icons on dark background). Note that the current implementation always use dark icons even when using a dark color scheme.