Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v3 design review (F. Clavert) #651

Open
6 of 8 tasks
inactinique opened this issue Jul 15, 2024 · 2 comments
Open
6 of 8 tasks

v3 design review (F. Clavert) #651

inactinique opened this issue Jul 15, 2024 · 2 comments
Assignees

Comments

@inactinique
Copy link
Collaborator

inactinique commented Jul 15, 2024

  • Table of content: in the v2, when we scroll down, the title appears on top of the TOC when it is not seeable anymore on top of the page. That should remain in the v3
  • Table of content: the bibliography does not appear there anymore
  • 'DATA' should be 'DATA & CODE'
  • Figures are in the 'code' tab because it is formally cells of code. It should not. It should be in the narrative or hermeneutics (depending on the choice of the author) layer
    • same for tables
  • when several cells of the hermeneutics or data layer are in the same layer and follow each other, they are separated by some pixels of the narrative layer. Should we let that?
  • images look sometimes cropped. Same for tables
  • How will we inform readers that the my binder session is starting / has started? (Because it might take some time before the 'run code' button is available).

In some cases, there can be today parts where there's a title in the hermeneutics layer and then only cell codes (code layer). Could we, in those cases, open the possibility of having titles in the data & code layer?

@eliselavy
Copy link
Collaborator

eliselavy commented Jul 19, 2024

Some improvment here: https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqbmtxcVRUS1c4a20lMkZtYWluJTJGcGFwZXIuaXB5bmI=?v=3

by @frederic-reis

  • launch of binder when you click on run code
  • reset button
  • data & code label
  • status message of the connection displayed on the right side
  • Remove of the connection status bar at the top of the article
  • Remove of the tools bar at the top of the cell

@eliselavy needs to provide notebook tagged with data

  • tagged data computanionel figures
  • tagged data code without producing output

eliselavy added a commit to jdh-observer/nAW4E5etkMR6 that referenced this issue Jul 19, 2024
danieleguido added a commit that referenced this issue Jul 26, 2024
@danieleguido
Copy link
Collaborator

concerning this:

How will we inform readers that the my binder session is starting / has started? (Because it might take some time before the 'run code' button is available).

there is now a session (with animations) info that enables start/stop kernel and show the status of the kernel, see below:

Screenshot 2024-07-26 at 12 18 56

danieleguido added a commit that referenced this issue Jul 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants