Update to hashbrown 0.9 #72
Conversation
The behavior of `drain_filter` has changed in this release: rust-lang/hashbrown#186
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 81.64% 81.56% -0.09%
==========================================
Files 10 10
Lines 752 754 +2
==========================================
+ Hits 614 615 +1
- Misses 138 139 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
You can tell I wasn't super comfortable with the parity previously implemented, thus leaving the clarifying comment.
The first half of the clarifying comment is also made incorrect by the change/fix, so it also needs to be changed.
I think were drain_filter to have been stable with these semantics originally, I wouldn't have felt the need to add the clarifying comment in the first place. I probably would have still added the comment had it been stable with retain's parity.
Until drain_filter is stabilized, I think the comment is definitely still valuable; once the method is stabilized, the comment may be judged unnecessary.
You can fix the rest of the comment and I'll merge this, or I'll get around to doing as such the next time I get some time to work on pushing this to be ready to integrate into rowan/r-a.
(Coverage diff is noise.)
Co-authored-by: Christopher Durham <cad97@cad97.com>
|
Applied your comment fix. |
|
bors: r+ |
|
Build succeeded: |
The behavior of
drain_filterhas changed in this release:rust-lang/hashbrown#186