Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Resimplify #2

Merged
merged 5 commits into from
Nov 14, 2019
Merged

Resimplify #2

merged 5 commits into from
Nov 14, 2019
+328 −409

Conversation

CAD97
Copy link
Owner

@CAD97 CAD97 commented Nov 14, 2019

cc @matklad; how does this API look now?

matklad
matklad reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, but I think we shouldn't hard-code Vec and use ExactSizeIterator instead

@CAD97 CAD97 merged commit 62cc9b7 into master Nov 14, 2019
@CAD97 CAD97 deleted the resimplify-a branch November 14, 2019 21:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAD97 @matklad