Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-217 Design QA changes and fixes #113

Merged
merged 3 commits into from
Sep 13, 2023
Merged

CRDCDH-217 Design QA changes and fixes #113

merged 3 commits into from
Sep 13, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Sep 7, 2023 •
edited
Loading

Overview

This builds on PR #109 and covers Design QA comments in CRDCDH-217:

  • 22
  • 21
  • 23
  • 20
  • 18 – Updated disabled button to #D9DEE4 per Hannah
  • 17 - Updated since it starts from Section A

Comments not addressed:

  • Comment 14 – Issue with the screenshot
  • Comment 7 – Addressed already
  • Comment 3 – Addressed already

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Sep 7, 2023
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Sep 11, 2023
@amattu2 amattu2 marked this pull request as ready for review September 12, 2023 16:43
@amattu2 amattu2 changed the base branch from CRDCDH-218 to mvp-1.0.0 September 13, 2023 15:07
@jonkiky jonkiky merged commit c3b4618 into mvp-1.0.0 Sep 13, 2023
@jonkiky jonkiky deleted the CRDCDH-217 branch September 13, 2023 15:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jonkiky jonkiky jonkiky approved these changes

@Alejandro-Vega Alejandro-Vega Awaiting requested review from Alejandro-Vega

@mtangmt mtangmt Awaiting requested review from mtangmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @jonkiky