Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-18 Model Navigator CDS Model #176

Merged
merged 27 commits into from
Nov 15, 2023
Merged

CRDCDH-18 Model Navigator CDS Model #176

merged 27 commits into from
Nov 15, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 20, 2023 •
edited
Loading

Overview

This PR updates the Data Model Navigator implementation per changes requested in CRDCDH-18.

Specifics

  • Completely refactors the Data Model Navigator implementation to support multiple models
  • Removes postbuild and postinstall scripts (not necessary anymore)
  • Implements the environment variable REACT_APP_DEV_ENV
  • Data model navigator was updated to support:
    • Custom file prefix config for every file download
    • Disable README download buttons / Hide README button if no README is specified
    • Override the ICDC Loading File examples – this will download from a pre-made ZIP
    • Override PDF header icon (Use CRDC-DH logo)
    • Override PDF footer text (Use CRDC-DH model url)
  • Transition the hard-coded ICDC model to CDS model (dynamically loaded)

Note: Your local environment should define REACT_APP_DEV_TIER as dev2

Note: The CCDI/ICDC data model page may (and should) throw and error when you try to visit it. This is by design.

Related Tickets

https://tracker.nci.nih.gov/browse/CRDCDH-18

@amattu2 amattu2 changed the title CRDCDH-18 Rename Submission Templates to Model Navigator CRDCDH-18 Model Navigator Updates Oct 23, 2023
@amattu2 amattu2 added this to the MVP-2.0.0 (M2) milestone Oct 25, 2023
@amattu2 amattu2 removed the MVP-2.0.0 label Oct 25, 2023
@amattu2
Test
760fe4e 
Signed-off-by: Alec M <alec.mattu@nih.gov>
@amattu2 amattu2 changed the title CRDCDH-18 Model Navigator Updates CRDCDH-18 Model Navigator CDS Model Nov 1, 2023
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Nov 6, 2023
@amattu2 amattu2 marked this pull request as ready for review November 8, 2023 20:53
@amattu2 amattu2 mentioned this pull request Nov 14, 2023
Closed
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 14, 2023
@amattu2
Copy link
Member Author

amattu2 commented Nov 14, 2023

Can be merged after review. But it needs to be Squash merged.

Screenshot 2023-11-14 at 2 01 05 PM

Alejandro-Vega
Alejandro-Vega approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 7ca7cf4 into mvp-2 Nov 15, 2023
@Alejandro-Vega Alejandro-Vega deleted the amattu2/CRDCDH-18-Updates branch November 15, 2023 17:53
@amattu2 amattu2 mentioned this pull request Nov 15, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 (MVP2-M2)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega