Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CRDCDH-579 Removed Error Count and Widgets for MVP2-M2 #201

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Nov 7, 2023

Overview

This PR aims to remove things that shouldn't be included in MVP2-M2, but will be included in the future.

Change Details (Specifics)

  • Removed Error Count column from Batch Table
  • Removed Pie Chart widgets from Submission Dashboard
  • Removed space between summary section and tabs
  • Moved and changed summary banner asset to be taller and fit new design

Related Ticket(s)

CRDCDH-579

…ions dashboard. These will be re-added in the future
@Alejandro-Vega Alejandro-Vega added this to the MVP-2.0.0 (M2) milestone Nov 7, 2023
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Nov 7, 2023
amattu2
amattu2 previously approved these changes Nov 8, 2023
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge if ready.

@Alejandro-Vega
Copy link
Collaborator Author

LGTM. Feel free to merge if ready.

@amattu2 Please re-review, I added additional changes. Thanks.

@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 8, 2023
@amattu2 amattu2 merged commit 03261ca into mvp-2 Nov 8, 2023
@amattu2 amattu2 deleted the CRDCDH-579 branch November 8, 2023 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants