Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CRDCDH-601 Copy Submission ID from Submission Dashboard #210

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Nov 15, 2023

Overview

This PR aims to add a way to display and copy the submission ID from the Submission Dashboard. This will be utilized while using the CLI.

Change Details (Specifics)

  • Added additional copy icon svg
  • Added section above the Submission Dashboard with Submission ID and a copy to clipboard button
  • Used URL param for submission ID since it is faster

Related Ticket(s)

CRDCDH-601

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Nov 15, 2023
@Alejandro-Vega Alejandro-Vega added this to the MVP-2.0.0 (M2) milestone Nov 15, 2023
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential concern added. Everything else LGTM.

@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 15, 2023
@amattu2 amattu2 merged commit 334b6ce into mvp-2 Nov 15, 2023
@amattu2 amattu2 deleted the CRDCDH-601 branch November 15, 2023 21:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants