Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove old styling dependencies #236

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Remove old styling dependencies #236

merged 3 commits into from
Dec 8, 2023

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Dec 7, 2023

Overview

This PR aims to remove @mui/styles and styled-components dependencies from the project. Also, to remove the --legacy-peer-deps flag from our node commands.

Change Details (Specifics)

  • Remove all withStyles and replace with MUI styled
  • Remove all styled-components references and replace with MUI styled
    NOTE: This affects Submission Request as well as header/footer. Will need to test carefully before merging.

Related Ticket(s)

N/A

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Dec 7, 2023
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Dec 7, 2023
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review December 7, 2023 22:47
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a comparison between this branch and the dev (M3) tier deployment; only found one "major" difference in styling and noted it below. There are a few almost-imperceivable spacing changes (under 0.5px of a difference) with some buttons/components on the questionnaire, but they can be ignored.

Awesome work @Alejandro-Vega!

@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 8, 2023
@amattu2 amattu2 merged commit c2d76ff into mvp-2.1.0 Dec 8, 2023
@amattu2 amattu2 deleted the remove-old-styling branch December 8, 2023 16:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants