Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CRDCDH-538 Data Submission QC Statistics (v2) #255

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 3, 2024

Overview

This PR introduces changes to the CRDCDH-538 implementation. We're still waiting on the final decision for which design to go with, so this is based off of Design 1.

Change Details (Specifics)

  • Rename the chart sections (Primary/Secondary charts)
  • Fix an issue with the charts reanimating occasionally when fetching the submission statistics. Caused by:
    • The submission stats API doesn't return the stats in a consistent order, so we're sorting them by the nodeName
    • Prevent rerendering of the ValidationStatistics and NodeChart by memoizing the entire component
  • Redesign the legend and make it interactive
  • Add the missing "Total XXX" count inside the primary chart when it's NOT being hovered over
  • Make the node charts interactive when hovering over a specific slice
  • Add interactive legend with filters

Related Ticket(s)

CRDCDH-538

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 3, 2024
@amattu2 amattu2 requested a review from Alejandro-Vega January 4, 2024 18:41
@amattu2 amattu2 marked this pull request as ready for review January 4, 2024 18:41
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 74726b8 into mvp-2.1.0 Jan 8, 2024
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-538 branch January 8, 2024 18:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants