Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-886 ICDC-specific props added to File Tran. Manifest DL #298

Merged
merged 1 commit into from
Mar 4, 2024
Merged

CRDCDH-886 ICDC-specific props added to File Tran. Manifest DL #298

merged 1 commit into from
Mar 4, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 4, 2024 •
edited
Loading

Overview

This PR addresses an issue with the Data Model Navigator > All Data Templates (TSV) > File Transfer Manifest download including ICDC-specific columns added:

  • original_file_size
  • original_md5sum

Change Details (Specifics)

  • Update DMN to v1.1.23

Related Ticket(s)

CRDCDH-886

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Mar 4, 2024
@amattu2 amattu2 changed the title fix: ICDC-specific props added to File Tran. Manifest DL CRDCDH-886 ICDC-specific props added to File Tran. Manifest DL Mar 4, 2024
@amattu2 amattu2 requested a review from Alejandro-Vega March 4, 2024 16:19
@amattu2 amattu2 marked this pull request as ready for review March 4, 2024 16:19
Alejandro-Vega
Alejandro-Vega approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The 2 extra columns in file transfer manifest seemed to have been removed.

@Alejandro-Vega Alejandro-Vega merged commit cb0c9bd into mvp-2.1.0 Mar 4, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the amattu2-remove-extra-ICDC-props branch March 4, 2024 17:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega