Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-988 Enforce consistent link styling #330

Merged
merged 1 commit into from
Apr 3, 2024
Merged

CRDCDH-988 Enforce consistent link styling #330

merged 1 commit into from
Apr 3, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Apr 3, 2024 •
edited
Loading

Overview

MVP-2 M3 bug fix for links within a SectionGroup description were not underlined as expected.

Change Details (Specifics)

  • Enforce underline and font weight on anchors nested in a SectionGroup description
  • Move styling out of SectionMetadata.tsx
  • Cleanup code styling in SectionGroup
  • Move Props definition above the SectionGroup component

Related Ticket(s)

CRDCDH-988

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Apr 3, 2024
@amattu2 amattu2 marked this pull request as ready for review April 3, 2024 17:34
@amattu2 amattu2 requested a review from Alejandro-Vega April 3, 2024 17:34
Alejandro-Vega
Alejandro-Vega approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit dfa7204 into mvp-2.1.0 Apr 3, 2024
3 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-988 branch April 3, 2024 17:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega