Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CRDCDH-1114 Submission Request Free-text Delimiter #365

Merged
merged 4 commits into from
May 14, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented May 10, 2024

Overview

This PR modifies the default value delimiter for properties on the Submission Request Review Page and adds a contextual tooltip to indicate the expected delimiter.

Change Details (Specifics)

  • Add delimiter prop to ReviewDataListingProperty
  • Remove the delimiter when displaying the value line-by-line (e.g. no longer include the , at the end of the value)
  • Override default comma (,) delimiter for the fields:
    • B: Repository > Other Data Types (free text)
    • C: Other Cancer Types (free text)
    • C: Pre-Cancer Types (free text)
    • C: Other Specie(s) Involved (free text)
    • D: Other Clinical Data Types (free text)
    • D: Other Data Types (free text)
  • Add tooltips for the above fields to indicate that a pipe (|) should be used to separate values

Related Ticket(s)

CRDCDH-1114

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone May 10, 2024
@amattu2 amattu2 marked this pull request as ready for review May 13, 2024 20:25
@amattu2 amattu2 requested a review from Alejandro-Vega May 13, 2024 20:25
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and working as expected!

@Alejandro-Vega Alejandro-Vega merged commit 29de4b7 into mvp-2.1.0 May 14, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-1114 branch May 14, 2024 14:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants