Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CRDCDH-1137 Allow validation in Submitted state #368

Merged
merged 2 commits into from
May 16, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented May 14, 2024

Overview

This PR covers a missing requirement that Data Curators or Admins should be able to validate a Submitted data submission. These changes should only effect Data Curators and Admins for a Data Submission in the "Submitted" state – Nothing else should change...

Note

When migrating to v3.0.0, I have test coverage for these changes written already, I just need to migrate them.

Change Details (Specifics)

  • Rewrite the validate permission map to be a simplified object.
    • Key: Submission Status
    • Value: List of Roles that can validate
  • Create a util to determine what the default Validation Target should be, we had one for the Validation Type already
  • Disable "New" validation target if the submission is Submitted
    • This is already disabled in statuses beyond "Submitted"

Related Ticket(s)

CRDCDH-1137

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone May 14, 2024
@amattu2 amattu2 marked this pull request as ready for review May 15, 2024 14:58
@amattu2 amattu2 requested a review from Alejandro-Vega May 15, 2024 14:58
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me and is working as expected! Nice job!

@Alejandro-Vega Alejandro-Vega merged commit bb937e8 into mvp-2.1.0 May 16, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-1137 branch May 16, 2024 14:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants