Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CRDCDH-33 Change piAsPrimaryContact functionality, change Form Banner Title #46

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jul 17, 2023

Overview

This PR covers requirements changes to CRDCDH-33 and includes a bug fix relating to piAsPrimaryContact functionality.

Specifics:

  • piAsPrimaryContact changes
    • When checked, all Primary Contact fields copy the latest saved PI information
    • The fields are conditionally "required" dependent on current checked state
  • Updates to submission form banner, now consistent with HTML5 title of the page
  • Fixed "readOnly" styling of the Autocomplete input (broken)

Warning: This change is dependent on PR #45.

@amattu2 amattu2 changed the base branch from mvp-1.0.0 to CRDCDH-54 July 17, 2023 14:33
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jul 17, 2023
@amattu2 amattu2 marked this pull request as ready for review July 24, 2023 16:37
Base automatically changed from CRDCDH-54 to mvp-1.0.0 July 26, 2023 14:00
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jul 26, 2023
@jonkiky jonkiky merged commit 4dfe587 into mvp-1.0.0 Jul 26, 2023
@amattu2 amattu2 deleted the CRDCDH-33-Changes branch July 26, 2023 16:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants