Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-176 New Progress Bar Icons #59

Merged
merged 8 commits into from
Aug 2, 2023
Merged

CRDCDH-176 New Progress Bar Icons #59

merged 8 commits into from
Aug 2, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jul 27, 2023 •
edited
Loading

Overview

Implements the updated requirements for the questionnaire form defined in CRDCDH-176. Specifically:

  • Updates Scroll to top implementation to cover Progress Bar navigation events
  • Update the Review section icons for the Progress Bar (aka sidebar)
  • Fix misc. related test cases failing

Note: This PR is based off #60 as that implements the scroll-to-top functionality.

@amattu2 amattu2 changed the title CRDCDH-176 New Progress Bar Icons & Window scroll on navigate CRDCDH-176 New Progress Bar Icons Jul 27, 2023
@amattu2 amattu2 marked this pull request as ready for review July 27, 2023 19:29
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jul 28, 2023
@amattu2 amattu2 changed the base branch from mvp-1.0.0 to CRDCDH-165 August 1, 2023 18:49
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Aug 1, 2023
@jonkiky jonkiky merged commit 9d47aef into CRDCDH-165 Aug 2, 2023
@jonkiky jonkiky deleted the CRDCDH-176 branch August 2, 2023 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jonkiky jonkiky jonkiky approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

@Alejandro-Vega Alejandro-Vega Awaiting requested review from Alejandro-Vega

@JoonLeeNIH JoonLeeNIH Awaiting requested review from JoonLeeNIH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @jonkiky