Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-95 Add apollo client and integrated with mock api server #8

Merged
merged 2 commits into from
Jun 23, 2023
Merged

CRDCDH-95 Add apollo client and integrated with mock api server #8

merged 2 commits into from
Jun 23, 2023

Conversation

jonkiky
Copy link
Collaborator

@jonkiky jonkiky commented Jun 20, 2023 •
edited
Loading

  1. Added Apollo Graphql client
  2. Sample code for fetching data from mock api server
  3. Code styling update -- auto correction

@jonkiky jonkiky changed the base branch from main to dev June 20, 2023 19:27
@amattu2

This comment was marked as resolved.

# to view
amattu2
amattu2 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetches data as expected. LGTM.

Alejandro-Vega
Alejandro-Vega approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works well on my end.

@jonkiky jonkiky merged commit 538e05e into dev Jun 23, 2023
@jonkiky jonkiky deleted the CRDCDH-95 branch June 23, 2023 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

@JoonLeeNIH JoonLeeNIH Awaiting requested review from JoonLeeNIH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonkiky @amattu2 @Alejandro-Vega