Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-33 Update for Requirements changes #84

Merged
merged 5 commits into from
Aug 10, 2023
Merged

CRDCDH-33 Update for Requirements changes #84

merged 5 commits into from
Aug 10, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Aug 8, 2023 •
edited
Loading

Overview

This PR captures changes to Section A per requirements changes outlined in CRDCDH-33.

Specifics:

  • Changed "Email address" labels to just "Email"
  • Same as Principal Investigator checkbox hides the Primary Contact input fields
  • Phone numbers can now contain numeric, dash, and spaces
  • Added custom email validator (for some reason emails missing a TLD was valid..?)
  • Use custom error message for emails (to indicate they're invalid)

@amattu2 amattu2 marked this pull request as ready for review August 9, 2023 13:23
@jonkiky jonkiky merged commit 6d16536 into mvp-1.0.0 Aug 10, 2023
@jonkiky jonkiky deleted the CRDCDH-33-Final branch August 10, 2023 14:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jonkiky jonkiky jonkiky approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

@Alejandro-Vega Alejandro-Vega Awaiting requested review from Alejandro-Vega

@JoonLeeNIH JoonLeeNIH Awaiting requested review from JoonLeeNIH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @jonkiky