Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CRDCDH-35 Redesign Form Section B #9

Merged
merged 27 commits into from
Jun 26, 2023
Merged

CRDCDH-35 Redesign Form Section B #9

merged 27 commits into from
Jun 26, 2023

Conversation

Alejandro-Vega
Copy link
Collaborator

Overview
This PR is a redesign of Form Section B for the ticket CRDCDH-35 The original implementation for the section was created by @amattu2.

  • Modified spacing and positioning of Form B
  • Updated styling and spacing for every type of input (textfield, select, autocomplete, etc.)
  • Updated styling and spacing for each section of the form
  • Added section for Planned Publications
  • Imported icons (dropdown arrows, and calendar) and added them as adornment to corresponding inputs
  • Created DatePickerInput and added Dayjs dependency necessary for the DatePicker MUI component. If we want to switch date library adapters it should be addressed.

@Alejandro-Vega
Added MUI date picker dependencies and wrapped LocalizationProvider a…
3f70c67 
…round application
@Alejandro-Vega
Added Nunito google font
51e97a4
@Alejandro-Vega
Styled FormView navigation buttons and controls
5a0ccc6
@Alejandro-Vega
Created AddRemoveButton to be reusable when adding or removing conten…
dbb1273 
…t, while still maintaining consistent button styling
@Alejandro-Vega
Updated form title and fonts
63c7286
@Alejandro-Vega
Updated text, select, and autocomplete input styling
38f6e4e
@Alejandro-Vega
Added plannedPublications to Application and example data to the simu…
4e82de8 
…lated state
@Alejandro-Vega
Updated styling for Publication and Repository sections. As well as t…
874e8c5 
…he SectionGroup itself. Also added the ability to include a description and an endButton beside the title of a SectionGroup
@Alejandro-Vega
Updated Section B content, as well as added Planned Publications sect…
6c9c946 
…ion and content. Create a tooltip component to better match the styling of our tooltips. I also created DatePickerInput, but it is in an unfinished state and used as a placeholder currently
@Alejandro-Vega
Added input adornment icon assets necessary for autocomplete, select,…
0c21af4 
… and date picker inputs
@Alejandro-Vega
Updated plannedPublications type
c37a0ae
@Alejandro-Vega
Updated plannedPublication and tooltip spacing. Also, date picker inp…
7ec40f4 
…ut, autocomplete input, and select input styling and props
@Alejandro-Vega
Created a configuration file for Questionnaire Section B Funding List
0d9c563
@Alejandro-Vega
Updated section B to use expectedDate instead and also modified fundi…
ef9c0e0 
…ng agency to be a select input
@Alejandro-Vega
Removed withStyles, removed unecessary props, add make it so planned …
d3076c2 
…publications and repositories gets reset to empty array if none are provided. Also updated AddRemoveButton to use styled instead as well as adding convenient props
@Alejandro-Vega
Converted components to use styled instead of withStyles
be52249
@Alejandro-Vega
Added error validation to DatePickerInput and converted it to use sty…
07a83c1 
…led components instead
@Alejandro-Vega
Fixed typo
522bc23
@Alejandro-Vega
Replaced MUI tolltip icon with svg asset instead
cec80cb
@Alejandro-Vega
Fixed border color when focused and placeholder color for all inputs
60ef916
@Alejandro-Vega Alejandro-Vega marked this pull request as draft June 22, 2023 20:19
jonkiky
jonkiky approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@jonkiky jonkiky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! -- We may need to think about how to improve the way to styling. Should we need to move some styles into global sharing theme?

@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review June 23, 2023 16:19
@Alejandro-Vega
Copy link
Collaborator Author

@jonkiky I agree, we should find a better solution for styling and move common/repeated styling into global theme. The inputs for example all have very similar styling.

This was referenced Jun 23, 2023
Closed
Merged
@jonkiky jonkiky merged commit f310db3 into dev Jun 26, 2023
@jonkiky jonkiky deleted the CRDCDH-35-Redesign branch June 27, 2023 13:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jonkiky jonkiky jonkiky approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

@amattu2 amattu2 Awaiting requested review from amattu2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alejandro-Vega @jonkiky