-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CRDCDH-49 Form Auth Update #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty file to make testing easier. Added detailed tests for each role/orgRole to ensure the correct formMode is being calculated
…into CRDCDH-49-Form-Auth-Update
…ternal state and only pass the value onSubmit. This was done to avoid parent re-renders
… Review mode. Also updated test to skip Review section as it was causing it to break
amattu2
requested changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alejandro-Vega Very solid work here with the refactoring and comprehensive test cases. I added some comments which are optional, and one change required for the Fed lead role.
…ole, regardless if they have an orgRole. Made FederalLead default to view only for any other status. Moved OrgInfo type
amattu2
approved these changes
Aug 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVERVIEW
This PR aims to expand the amount of variables to calculate the form mode, rather than just "User" and "FederalLead" roles and form status. I separated the logic for calculating the form mode into its own utility file where I could create tests for it easier and also simplify the useFormMode hook itself.
TICKETS
CRDCDH-49
NOTE
This implementation assumes a user will only belong to a single organization.